Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix locale update all from GitHub actions #22763

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fix locale update all from GitHub actions #22763

merged 2 commits into from
Oct 30, 2023

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Oct 30, 2023 •
edited
Loading

Replaces #22752

Upgrading to zeitwerk meant that when locale:update_all tried to eager load the app, it tried to load a file that required qpid_proton be installed. This wasn't configured in the github action that was being done for locale:update_all. This change makes qpid_proton not necessary to run update_all.

Should be merged with ManageIQ/manageiq-providers-nuage#299

@jrafanie jrafanie requested a review from Fryguy as a code owner October 30, 2023 16:10
@jrafanie jrafanie mentioned this pull request Oct 30, 2023
Merged
Fryguy
Fryguy approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both LGTM - Would like @agrare to also review.

agrare
agrare approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependent PR merged, LGTM

@agrare agrare merged commit b009a9c into ManageIQ:master Oct 30, 2023
8 checks passed
@jrafanie jrafanie deleted the fix_locale_update_all_from_github_actions branch October 30, 2023 17:58
@Fryguy
Copy link
Member

Fryguy commented Oct 31, 2023

Backported to quinteros in commit 4d3581b.

commit 4d3581ba973e24151c0d6c1dcef3d248878d7315
Author: Adam Grare <[email protected]>
Date:   Mon Oct 30 13:55:41 2023 -0400

    Merge pull request #22763 from jrafanie/fix_locale_update_all_from_github_actions
    
    Fix locale update all from GitHub actions
    
    (cherry picked from commit b009a9c124ecef8332ce8efe42c8d5034f70d6ba)

Fryguy pushed a commit that referenced this pull request Oct 31, 2023
@agrare @Fryguy
Merge pull request #22763 from jrafanie/fix_locale_update_all_from_gi…
4d3581b 
…thub_actions

Fix locale update all from GitHub actions

(cherry picked from commit b009a9c)
@jrafanie jrafanie mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@Fryguy Fryguy Fryguy approved these changes

Assignees

@agrare agrare

Labels
bug quinteros/backported rails7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrafanie @Fryguy @agrare