Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix qpid proton require under zeitwerk - resolves rake locale:update_all failure in CI #22752

Closed
wants to merge 2 commits into from
Closed

Fix qpid proton require under zeitwerk - resolves rake locale:update_all failure in CI #22752

wants to merge 2 commits into from

Commits on Oct 27, 2023

  1. Ensure environment is loaded for a task that depends on it

    @jrafanie
    jrafanie committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    8f967d2 View commit details
    Browse the repository at this point in the history

  2. Don't eager load a class needing qpid_proton loaded at load time 

    This class can't be eager loaded because not all platforms install qpid_proton
and we need qpid_proton's class at load time.  We can't install qpid_proton on mac
but also don't want to install qpid's dependencies in CI in various providers, core,
etc.
    @jrafanie
    jrafanie committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    5dc641f View commit details
    Browse the repository at this point in the history