Pre-zeitwerk - Add inflections and acronyms #22620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OAuth acronym
* For loading OAuthSessionsController from ui-classic.
* GHT acronym
* For loading ApplicationHelper::Button::ViewGHT and ApplicationHelper::Button::ViewGHTAlways.
* REXML acronym
* Add acronym since the stdlib constant is all caps. This is needed to load TreeNode::REXML::Attribute. The other libraries that Use Rexml, such as MiqRexml, are gems and can do this on their own.
* UI acronym
* For loading ManageIQ::Providers::Ovirt::InfraManager::AdminUI
* SAP acronym
* For loading of ManageIQ::Providers::IbmCloud::PowerVirtualServers::CloudManager::SAPProfile
* VPC inflection
* Allows loading of ManageIQ::Providers::IbmCloud::Inventory::Collector::VPC. Note, an acronym for VPC would onflict with FixVpcFlavorsSti migration, so we're doing just this inflection.
* Tell the autoloader how to load the ui worker. This works around the UI acronym.
* MKS acronym
* For the remote_console/client_adapter/web_mks* tests
* DBus acronym.
* DBus is really D-Bus but we're not going to try to get that to work.
Fixes:
An error occurred while loading ./spec/lib/httpd_dbus_api_spec.rb.
Failure/Error: require 'httpd_dbus_api'
Zeitwerk::NameError:
expected file /Users/joerafaniello/Code/manageiq/lib/httpd_dbus_api.rb to define constant HttpdDbusApi, but didn't
* DDF acronym
Fixes:
NameError:
uninitialized constant DDF
Did you mean? Ddf
* IPMI acronym
* Allows loading of MiqIPMI in manageiq-gems-pending.
|
@miq-bot cross-repo-test /all |
55 tasks
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Jul 14, 2023
From Pull Request: ManageIQ/manageiq#22620
|
Checked commit jrafanie@6c1b362 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
Cross repo is green, other than the CIC provider recurring issue. |
Fryguy
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should be backward compatible changes and gets us closer to minimizing the changes for zeitwerk. Extracted from #22488
OAuth acronym
GHT acronym
REXML acronym
UI acronym
SAP acronym
VPC inflection
Tell the autoloader how to load the ui worker. This works around the UI acronym.
MKS acronym
DBus acronym.
DBus is really D-Bus but we're not going to try to get that to work. Fixes:
An error occurred while loading ./spec/lib/httpd_dbus_api_spec.rb. Failure/Error: require 'httpd_dbus_api'
Zeitwerk::NameError:
expected file /Users/joerafaniello/Code/manageiq/lib/httpd_dbus_api.rb to define constant HttpdDbusApi, but didn't
DDF acronym Fixes:
NameError: uninitialized constant DDF Did you mean? Ddf
IPMI acronym