Normalize screaming case html yaml for zeitwerk #22489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acronym make sense when the change to use Camelcase is hard or it reads better. We already use Yaml in constant names so it makes sense to convert this and get rid of YAML. Then, we also don't need to define an acronym.
We need to match MiqReport::Formatters:Html and MiqReport::Generator::Html or change them to also be HTML. I decided on Html because HTML would also require us to teach zeitwerk another acronym.
55 tasks
|
Checked commits jrafanie/manageiq@14a845f~...9e0de20 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint lib/manageiq/reporting/formatter.rb
|
Fryguy
approved these changes
May 2, 2023
|
@miq-bot cross-repo-test manageiq-ui-classic |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
May 2, 2023
From Pull Request: ManageIQ/manageiq#22489
|
verified that I couldn't find any references to the 2 screamers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from the zeitwerk PR
Normalize on Camelcase Html for consistency with loading
We need to match MiqReport::Formatters:Html and MiqReport::Generator::Html or
change them to also be HTML. I decided on Html because HTML would also require
us to teach zeitwerk another acronym.
Use Yaml as YAML looks awful in YAMLImportExportMixin
Acronym make sense when the change to use Camelcase is hard or it reads better.
We already use Yaml in constant names so it makes sense to convert this and get
rid of YAML. Then, we also don't need to define an acronym.