Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop scvmm/hyperv references since it was dropped in #22279 #22413

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Drop scvmm/hyperv references since it was dropped in #22279 #22413

merged 1 commit into from
Mar 17, 2023

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Mar 16, 2023 •
edited
Loading

jrafanie added a commit to jrafanie/manageiq-gems-pending that referenced this pull request Mar 16, 2023
@jrafanie
Drop winrm/scvmm/hyperv support since core dropped it
c88dd19 
See: ManageIQ/manageiq#22279

Related:
ManageIQ/manageiq#22413
ManageIQ/manageiq-smartstate#172

Found while looking at: ManageIQ#551
@jrafanie jrafanie mentioned this pull request Mar 16, 2023
Merged
Fryguy
Fryguy reviewed Mar 16, 2023
View reviewed changes
lib/manageiq/network_discovery/discovery.rb Outdated
Comment on lines 8 to 9
:msvirtualserver => "ManageIQ::Providers::Microsoft::Discovery",
:mswin => "ManageIQ::Providers::Microsoft::Discovery",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these 2 go away also?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye. More keywords to add to the grep.

@jrafanie jrafanie added the wip label Mar 16, 2023
@jrafanie
Copy link
Member Author

@miq-bot cross-repo-test /all including #22413, manageiq-smartstate#172, manageiq-gems-pending#556

@miq-bot miq-bot mentioned this pull request Mar 16, 2023
Open
miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Mar 16, 2023
@miq-bot
Running tests for jrafanie
93f23bf 
From Pull Request:  ManageIQ/manageiq#22413
@jrafanie jrafanie force-pushed the remove_scvmm_hyperv_support_due_to_22279 branch from c46d231 to 8e47670 Compare March 16, 2023 19:23
@miq-bot
Copy link
Member

miq-bot commented Mar 16, 2023

Checked commit jrafanie@8e47670 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
3 files checked, 2 offenses detected

app/models/ext_management_system.rb

spec/models/ext_management_system_spec.rb

@jrafanie jrafanie mentioned this pull request Mar 16, 2023
Merged
@jrafanie
Copy link
Member Author

jrafanie commented Mar 16, 2023 •
edited
Loading

I opened ManageIQ/manageiq-providers-ibm_cloud#447 to fix the test failure on ibm cloud from cross repot tests:

 Finished in 10.54 seconds (files took 1 minute 5.77 seconds to load)
  1103 examples, 0 failures
  
  Randomized with seed 16523
  
  Coverage report generated for RSpec to /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-ibm_cloud@0ddccb36f4dad739c9990d76e207b4815153d90e/coverage. 23490 / 57482 LOC (40.86%) covered.
  ** override_gem("manageiq-gems-pending", :path=>"/home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-gems-pending@daf76728d0bc2b291d08c8d7fb9d6551cd1c335d") at /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-ibm_cloud@0ddccb36f4dad739c9990d76e207b4815153d90e/spec/manageiq/bundler.d/overrides.rb:1
  ** override_gem("manageiq-smartstate", :path=>"/home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-smartstate@d94d7a702ebc285439413935ef222d848baa355c") at /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-ibm_cloud@0ddccb36f4dad739c9990d76e207b4815153d90e/spec/manageiq/bundler.d/overrides.rb:2
  ** Using session_store: ActionDispatch::Session::MemoryStore
  ** ManageIQ master, codename: Quinteros
  
  An error occurred while loading ./spec/models/manageiq/providers/ibm_cloud/vpc/cloud_tools_spec.rb. - Did you mean?
                      rspec ./spec/models/manageiq/providers/ibm_cloud/vpc/cloud_manager_spec.rb
                      rspec ./spec/models/manageiq/providers/ibm_cloud/vpc/cloud_manager/vm_spec.rb
                      rspec ./spec/models/manageiq/providers/ibm_cloud/vpc/cloud_manager/refresher_spec.rb
  
  Failure/Error: require 'logging'
  
  LoadError:
    cannot load such file -- logging
  # ./lib/manageiq/providers/ibm_cloud/cloud_tools.rb:3:in `<top (required)>'
  # ./spec/models/manageiq/providers/ibm_cloud/vpc/cloud_tools_spec.rb:3:in `<top (required)>'
  
  
  Top 0 slowest examples (0 seconds, 0.0% of total time):
  
  Finished in 0.00008 seconds (files took 7.38 seconds to load)
  0 examples, 0 failures, 1 error occurred outside of examples

@jrafanie
Copy link
Member Author

jrafanie commented Mar 16, 2023 •
edited by agrare
Loading

Cross repo results for the 3 related PRs. I think they're ready to be merged. Removing WIP.

@jrafanie jrafanie removed the wip label Mar 16, 2023
@agrare agrare merged commit c3ee812 into ManageIQ:master Mar 17, 2023
@jrafanie jrafanie deleted the remove_scvmm_hyperv_support_due_to_22279 branch March 17, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy left review comments

@agrare agrare agrare approved these changes

@kbrock kbrock Awaiting requested review from kbrock kbrock is a code owner

Assignees

@agrare agrare

Labels
providers technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrafanie @miq-bot @Fryguy @agrare