[WIP] EL9 RPM Sqlite3 DB support #201
Conversation
|
I'd be happy merging specs as is ahead of actually implementing anything. |
| it "returns a list of rpm packages" do | ||
| result = described_class.new(fs) | ||
|
|
||
| expect(result.instance_variable_get(:@packages).count).to eq(690) |
There was a problem hiding this comment.
I'm not sure why we don't have an attr_reader for @packages here, toXml and toString are the only "interface" methods but I think access to packages would be handy also
agrare
force-pushed
the
miq_rpm_packages_el9
branch
from
c5441ac
to
6cff95a
Compare
agrare
force-pushed
the
miq_rpm_packages_el9
branch
from
6cff95a
to
43f8f90
Compare
| } | ||
|
|
||
| # | ||
| # Nubbers on disk are in network byte order. |
agrare
force-pushed
the
miq_rpm_packages_el9
branch
2 times, most recently
from
cd7f0b9
to
654c48a
Compare
lib/db/MiqSqlite/MiqSqlite3Table.rb
Outdated
| @@ -63,7 +63,7 @@ def decodeSchema | |||
| return if @type != "table" || @name[0..6] == "sqlite_" # Names beginning with sqlite_ are internal to engine | |||
| @columns = [] | |||
| sql = @sql.gsub(/[\n\r]/, "") | |||
| re1 = /\s*CREATE\s+TABLE\s+(\w+)\s*\((.*)\)\s*/ | |||
| re1 = /\s*CREATE\s+TABLE\s+'?(\w+)'?\s*\((.*)\)\s*/ | |||
There was a problem hiding this comment.
That's interesting - I've never seen quotes before. Also note that technically the table name could have a . in it as well (i.e. <schema_name>.<table_name>)
|
@agrare More out of curiosity, what's the approach here? I'm seeing refactoring into separate modules + specs...is the plan to do an initial refactor, then merge, then add the new DB support? |
|
@Fryguy so I see this as two high level issues,
So the plan is:
So I'm rebasing this on top of the sqlite3 fixes |
|
Moving forward I wonder if it's better to use the sqlite library instead of rolling our own. Not sure if that is with investigation or not. I'd rather do whats more expedient at this time, but I'm also wondering what bugs will lurk in the corners. |
Yes I did look into that originally, but I don't think that will work with the way that we handle loading the filesystem via MiqFs in SSA. We'd need a "real" file since the interface is a path and all of the loading of the database is done in C-ext code. (Another reason I'd like to use FUSE instead eventually so that we could "mount" the filesystem and use more standardized tools based on files/paths) |
agrare
force-pushed
the
miq_rpm_packages_el9
branch
from
654c48a
to
6adc493
Compare
agrare
force-pushed
the
miq_rpm_packages_el9
branch
from
6adc493
to
37ca67f
Compare
Depends on: