Add documentation on how to build a hotfix #505
Conversation
| build a hotfix against, for example `manageiq-release-18.0-1.el9.src.rpm` | ||
|
|
||
| ```sh | ||
| docker run --rm -v `pwd`/OPTIONS:/root/OPTIONS -v `pwd`/BUILD:/root/BUILD $USER/rpm_build:radjabov-hotfix build_hotfix |
There was a problem hiding this comment.
NOTE instead of a separate volume map for the hotfix dir it seemed easier to just map ./BUILD so the artifacts and the srpm are in one place but if this doesn't work for some reason I can change it
There was a problem hiding this comment.
I thought we already had this documented, but maybe not. @bdunne Please review.
There was a problem hiding this comment.
Yeah I didn't see any so this started as me just taking notes on what I had to do so we had something to reference in the future
There was a problem hiding this comment.
Having the docker command here is helpful
So much time goes between needing to build rpms that I often forget.
Re: "I thought we already had this documented"
On the mac, mapping the BUILD volume was horribly slow. Think I mapped BUILD/rpm to speed it up.
I remember putting together documentation on this a while back but people seemed to disagree on the best approach.
There was a problem hiding this comment.
On the mac, mapping the BUILD volume was horribly slow. Think I mapped BUILD/rpm to speed it up.
I remember putting together documentation on this a while back but people seemed to disagree on the best approach.
Oh did you have hotfix documentation? Or you mean documentation on how to build rpms on a mac?
agrare
changed the title
|
|
||
| Which will create a patch file: `0001-Merge-pull-request-23123-from-agrare-fix_miq_request.patch` | ||
|
|
||
| Next we have to change the file location to match the RPM BUILDDIR, for a patch in the core rpm this will be e.g. `manageiq-core-18.0-1` |
There was a problem hiding this comment.
I'm not totally sure what you did here.
Can you show us a diff of the fix_miq_request.patch?
Was it just a change to first line?
Yes, meta, a diff of a diff, but just trying to understand what was done here.
or maybe show it as a sed command?
TODO: