Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove aiohttp #504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove aiohttp #504

wants to merge 1 commit into from

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Sep 6, 2024

This was added to support all possible vmware clients But we don't use this client, none of our customers requested it and it looks to have security issues

@Fryguy your call if we want to go this route or want to resolve the issues

This was added to support all possible vmware clients
But we don't use this client, none of our customers requested it
and it looks to have security issues
@kbrock kbrock added the bug Something isn't working label Sep 6, 2024
@Fryguy
Copy link
Member

Fryguy commented Sep 6, 2024

I'm curious what @agrare thinks. We didn't have it before, so it's not like it worked previously.

@agrare Background is there are 2 vmware clients for python.

I'm pretty sure we've only every worked with community/vmware, but I wasn't sure if you had other experiences in the wild.

@kbrock
Copy link
Member Author

kbrock commented Sep 6, 2024

In that note. We've worked fine without the git package

@agrare
Copy link
Member

agrare commented Sep 6, 2024

I haven't run into it previously but it states it is part of the "Red Hat Ansible Certified Content for VMware"
Are these security issues with aiohttp being ignored by upstream?

@kbrock
Copy link
Member Author

kbrock commented Sep 10, 2024

I just added in #495
Think we want to drop this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants