Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Podman as dependency for manageiq-appliance #401

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

agrare
Copy link
Member

@agrare agrare commented Jun 29, 2023

Podman will be used to run containers for workflows and potentially
workers in the future.

Screenshot from 2023-06-29 12-59-43

ManageIQ/manageiq#22311

Podman will be used to run containers for workflows and potentially
workers in the future.
@miq-bot
Copy link
Member

miq-bot commented Jun 29, 2023

Checked commit agrare@951e5bb with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 👍

@agrare agrare requested review from bdunne and Fryguy June 29, 2023 17:23
@agrare agrare added the enhancement New feature or request label Jun 29, 2023
Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just want @bdunne to also approve

@bdunne bdunne merged commit e506947 into ManageIQ:master Jul 7, 2023
@agrare agrare deleted the add_appliance_dependency_podman branch July 7, 2023 13:42
@Fryguy
Copy link
Member

Fryguy commented Jul 25, 2023

Backported to petrosian in commit 44ca156.

commit 44ca156312b0f3c2dd3e26ad87338e24459ac16f
Author: Brandon Dunne <[email protected]>
Date:   Thu Jul 6 23:46:03 2023 -0400

    Merge pull request #401 from agrare/add_appliance_dependency_podman
    
    Add Podman as dependency for manageiq-appliance
    
    (cherry picked from commit e506947d634e19be646624ba77a0aab73830775d)

Fryguy pushed a commit that referenced this pull request Jul 25, 2023
Add Podman as dependency for manageiq-appliance

(cherry picked from commit e506947)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants