-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PhotonOS icon #904
Add PhotonOS icon #904
Conversation
@agrare Even though this adds the icon, I'm not sure what will detect it without it being in the list of normalized operating systems here: https://github.com/ManageIQ/manageiq/blob/master/app/models/operating_system.rb#L13 |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
1 similar comment
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
@Fryguy I think something like "linux_photon" or "linux_photon_os" would fit better with the existing OS map, https://github.com/ManageIQ/manageiq/pull/23188/files#diff-a529bec9a81ca60f57c0d099561a26d6d90e995ee16d0411ec476ed17a6f6a78R32 |
@agrare Done. |
Checked commit Fryguy@3a4cf52 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Moved to ManageIQ/manageiq-decorators#107 |
Closes #869