Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PhotonOS icon #904

Closed
wants to merge 1 commit into from
Closed

Add PhotonOS icon #904

wants to merge 1 commit into from

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Mar 7, 2024

Closes #869

@Fryguy
Copy link
Member Author

Fryguy commented Mar 7, 2024

@agrare Even though this adds the icon, I'm not sure what will detect it without it being in the list of normalized operating systems here: https://github.com/ManageIQ/manageiq/blob/master/app/models/operating_system.rb#L13

@miq-bot miq-bot added the stale label Jun 10, 2024
@miq-bot
Copy link
Member

miq-bot commented Jun 10, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

1 similar comment
@miq-bot
Copy link
Member

miq-bot commented Sep 16, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@Fryguy Fryguy removed the stale label Sep 16, 2024
@Fryguy Fryguy changed the title Add ProtonOS icon Add PhotonOS icon Sep 16, 2024
@agrare
Copy link
Member

agrare commented Sep 16, 2024

Here is the guestFullName for a photon os vm
image

@agrare
Copy link
Member

agrare commented Sep 16, 2024

@Fryguy I think something like "linux_photon" or "linux_photon_os" would fit better with the existing OS map, https://github.com/ManageIQ/manageiq/pull/23188/files#diff-a529bec9a81ca60f57c0d099561a26d6d90e995ee16d0411ec476ed17a6f6a78R32

@Fryguy
Copy link
Member Author

Fryguy commented Sep 16, 2024

@agrare Done.

@miq-bot
Copy link
Member

miq-bot commented Sep 16, 2024

Checked commit Fryguy@3a4cf52 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@Fryguy
Copy link
Member Author

Fryguy commented Sep 16, 2024

Moved to ManageIQ/manageiq-decorators#107

@Fryguy Fryguy closed this Sep 16, 2024
@Fryguy Fryguy deleted the photon_icon branch September 16, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an icon for VMware PhotonOS
3 participants