Skip to content

Commit

Permalink
Fix CloudNetwork#delete_cloud_network argument error
Browse files Browse the repository at this point in the history
The core `CloudNetwork#raw_delete_cloud_network` method takes an
optional `options` hash as the first parameter.
  • Loading branch information
agrare committed Jun 13, 2023
1 parent a31f0c8 commit 22286e1
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ def self.raw_create_cloud_network(ext_management_system, options)
raise MiqException::MiqNetworkCreateError, parsed_error, e.backtrace
end

def raw_delete_cloud_network
def raw_delete_cloud_network(_options = {})
with_notification(:cloud_network_delete,
:options => {
:subject => self,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,30 @@
end

context "#update_cloud_network" do
it "updates the cloud network" do
options = {"name" => "new-name"}

expect(service).to receive(:update_network).with(cloud_network.ems_ref, options)
cloud_network.update_cloud_network(options)
end

it 'catches errors from provider' do
expect(service).to receive(:update_network).and_raise(bad_request)
expect { cloud_network.raw_update_cloud_network({}) }.to raise_error(MiqException::MiqNetworkUpdateError)
expect { cloud_network.update_cloud_network({}) }.to raise_error(MiqException::MiqNetworkUpdateError)
end
end

context "#delete_cloud_network" do
before { NotificationType.seed }

it "deletes the cloud network" do
expect(service).to receive(:delete_network).with(cloud_network.ems_ref)
cloud_network.delete_cloud_network({})
end

it 'catches errors from provider' do
expect(service).to receive(:delete_network).and_raise(bad_request)
expect { cloud_network.raw_delete_cloud_network }.to raise_error(MiqException::MiqNetworkDeleteError)
expect { cloud_network.delete_cloud_network({}) }.to raise_error(MiqException::MiqNetworkDeleteError)
end
end
end
Expand Down

0 comments on commit 22286e1

Please sign in to comment.