Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move opentofu-runner container image name to an environment variable #25

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented May 13, 2024

Allow changes to the opentofu-runner image to be done simply by modifying an environment variable or an application setting.

ManageIQ/manageiq#22956

@agrare agrare added the enhancement New feature or request label May 13, 2024
@agrare agrare requested review from Fryguy and bdunne May 13, 2024 16:22
@@ -17,4 +17,5 @@
:workers:
:worker_base:
:opentofu_worker:
:conatiner_image: docker.io/manageiq/opentofu-runner:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:conatiner_image: docker.io/manageiq/opentofu-runner:latest
:container_image: docker.io/manageiq/opentofu-runner:latest

Allow changes to the opentofu-runner image to be done simply by
modifying an environment variable or an application setting.
@agrare agrare force-pushed the move_opentofu_runner_container_image_env_var branch from 4e5b960 to 2e33c10 Compare May 13, 2024 17:44
@miq-bot
Copy link
Member

miq-bot commented May 13, 2024

Checked commit agrare@2e33c10 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@Fryguy Fryguy merged commit ac41442 into ManageIQ:master May 13, 2024
4 checks passed
@Fryguy Fryguy self-assigned this May 13, 2024
@agrare agrare deleted the move_opentofu_runner_container_image_env_var branch May 13, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants