Allow StateVarHash to YAML.load from runtime instantiate #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we allowed it to be permitted in serialized columns, but this test also requires it be permitted from miq_ae_workspace_runtime.rb instantiate.
agrare
approved these changes
Dec 18, 2023
This was referenced Dec 18, 2023
|
Checked commit jrafanie@9803f49 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
Cross repo is green ManageIQ/manageiq-cross_repo-tests#835 merging on red |
jrafanie
deleted the
ruby31_specify_permitted_classes_in_test_for_state_var_hash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we allowed it to be permitted in serialized columns, but this test also requires it be permitted from miq_ae_workspace_runtime.rb instantiate.
Like ManageIQ/manageiq-providers-vmware#892, this depends on: