Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for ColorTypes to 0.12, (keep existing compat) #4502

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the ColorTypes package from 0.8, 0.9, 0.10, 0.11 to 0.8, 0.9, 0.10, 0.11, 0.12.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@SimonDanisch SimonDanisch reopened this Oct 21, 2024
@SimonDanisch SimonDanisch added the skip-changelog Skips changelog enforcer label Oct 21, 2024
@MakieBot
Copy link
Collaborator

MakieBot commented Oct 21, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 6.40s (6.33, 6.46) 0.04+- 161.49ms (159.36, 163.83) 1.42+- 475.79ms (469.47, 490.62) 7.57+- 8.47ms (8.40, 8.57) 0.06+- 26.04ms (25.91, 26.15) 0.08+-
master 6.39s (6.36, 6.43) 0.02+- 162.51ms (158.35, 168.69) 3.37+- 474.00ms (467.92, 494.94) 9.74+- 8.45ms (8.30, 8.55) 0.09+- 26.10ms (25.95, 26.45) 0.18+-
evaluation 1.00x invariant, 0.01s (0.26d, 0.64p, 0.03std) 1.01x invariant, -1.01ms (-0.39d, 0.48p, 2.40std) 1.00x invariant, 1.79ms (0.21d, 0.71p, 8.66std) 1.00x invariant, 0.02ms (0.29d, 0.60p, 0.07std) 1.00x invariant, -0.07ms (-0.48d, 0.40p, 0.13std)
CairoMakie 6.43s (6.32, 6.61) 0.10+- 180.56ms (172.88, 197.15) 8.15+- 219.54ms (205.65, 239.14) 11.46+- 8.46ms (8.13, 8.83) 0.28+- 1.24ms (1.21, 1.28) 0.02+-
master 6.44s (6.27, 6.56) 0.10+- 186.14ms (175.13, 193.53) 7.70+- 221.36ms (213.26, 231.22) 6.90+- 8.67ms (8.41, 9.04) 0.27+- 1.25ms (1.23, 1.28) 0.02+-
evaluation 1.00x invariant, -0.02s (-0.16d, 0.78p, 0.10std) 1.03x invariant, -5.58ms (-0.70d, 0.21p, 7.93std) 1.01x invariant, -1.82ms (-0.19d, 0.73p, 9.18std) 1.03x invariant, -0.22ms (-0.79d, 0.17p, 0.28std) 1.01x invariant, -0.02ms (-0.84d, 0.14p, 0.02std)
WGLMakie 7.28s (7.05, 7.70) 0.22+- 199.59ms (170.69, 222.91) 17.42+- 6.22s (5.60, 6.60) 0.32+- 14.31ms (13.17, 15.68) 0.86+- 141.49ms (132.82, 148.77) 5.93+-
master 7.05s (6.86, 7.26) 0.13+- 182.15ms (172.00, 201.36) 10.43+- 6.31s (6.08, 6.62) 0.22+- 13.96ms (12.97, 14.78) 0.65+- 143.44ms (134.85, 149.62) 5.61+-
evaluation 0.97x slower X, 0.23s (1.27d, 0.04p, 0.17std) 0.91x slower❌, 17.44ms (1.22d, 0.05p, 13.92std) 1.01x invariant, -0.09s (-0.33d, 0.55p, 0.27std) 0.98x invariant, 0.35ms (0.45d, 0.41p, 0.76std) 1.01x invariant, -1.94ms (-0.34d, 0.54p, 5.77std)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog enforcer
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants