Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve picking tests #4488

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Improve picking tests #4488

merged 5 commits into from
Oct 16, 2024

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Oct 16, 2024

Description

Changes:

  • make GLMakie check for heatmap path less brittle
  • add check for WGLMakie
  • move test to referenceimage tests
  • add refimg (with set px_per_unit), testing pick(scene, ::Rect2i) for the full scene
  • fix WGLMakie pick(scene, ::Rect2f)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@ffreyer ffreyer marked this pull request as ready for review October 16, 2024 11:11
@MakieBot
Copy link
Collaborator

MakieBot commented Oct 16, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 5.21s (5.09, 5.28) 0.07+- 115.33ms (109.43, 127.66) 5.86+- 501.07ms (422.55, 688.22) 116.04+- 9.31ms (8.26, 9.88) 0.60+- 26.37ms (25.81, 26.69) 0.29+-
master 5.26s (5.16, 5.34) 0.08+- 115.43ms (110.31, 123.37) 4.48+- 430.03ms (416.23, 450.84) 11.22+- 9.51ms (8.48, 9.84) 0.48+- 26.43ms (25.98, 26.65) 0.22+-
evaluation 1.01x invariant, -0.04s (-0.61d, 0.28p, 0.07std) 1.00x invariant, -0.1ms (-0.02d, 0.97p, 5.17std) 0.86x noisy🤷‍♀️, 71.04ms (0.86d, 0.16p, 63.63std) 1.02x invariant, -0.2ms (-0.37d, 0.51p, 0.54std) 1.00x invariant, -0.05ms (-0.21d, 0.70p, 0.26std)
CairoMakie 5.00s (4.85, 5.10) 0.10+- 110.46ms (108.79, 111.85) 1.13+- 168.11ms (165.18, 173.96) 2.92+- 9.30ms (9.05, 9.79) 0.27+- 1.18ms (1.14, 1.23) 0.03+-
master 4.89s (4.85, 4.91) 0.02+- 111.59ms (108.99, 115.76) 2.50+- 171.13ms (166.77, 187.22) 7.27+- 9.28ms (9.08, 9.53) 0.20+- 1.19ms (1.14, 1.22) 0.04+-
evaluation 0.98x slower X, 0.11s (1.47d, 0.03p, 0.06std) 1.01x invariant, -1.13ms (-0.58d, 0.31p, 1.82std) 1.02x invariant, -3.01ms (-0.54d, 0.34p, 5.09std) 1.00x invariant, 0.02ms (0.09d, 0.88p, 0.24std) 1.01x invariant, -0.01ms (-0.17d, 0.76p, 0.04std)
WGLMakie 5.54s (5.42, 5.64) 0.08+- 113.89ms (110.13, 124.31) 5.06+- 5.26s (4.99, 5.54) 0.25+- 12.46ms (12.02, 13.61) 0.54+- 136.32ms (127.49, 157.99) 10.36+-
master 5.68s (5.61, 5.78) 0.07+- 110.81ms (109.19, 112.43) 1.26+- 5.03s (4.94, 5.17) 0.09+- 12.50ms (12.24, 12.93) 0.28+- 133.68ms (126.58, 144.07) 6.02+-
evaluation 1.03x faster ✓, -0.15s (-2.02d, 0.00p, 0.07std) 0.97x invariant, 3.09ms (0.84d, 0.16p, 3.16std) 0.96x invariant, 0.22s (1.18d, 0.06p, 0.17std) 1.00x invariant, -0.04ms (-0.09d, 0.87p, 0.41std) 0.98x invariant, 2.64ms (0.31d, 0.57p, 8.19std)

@ffreyer ffreyer merged commit 833be1d into master Oct 16, 2024
18 checks passed
@ffreyer ffreyer deleted the ff/better-picking-tests branch October 16, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants