Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload of new refimages #4484

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix upload of new refimages #4484

merged 1 commit into from
Oct 15, 2024

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Oct 15, 2024

Description

The new images weren't included in the updated refimages.

@ffreyer ffreyer added the skip-changelog Skips changelog enforcer label Oct 15, 2024
@ffreyer ffreyer merged commit d7aafde into master Oct 15, 2024
14 of 16 checks passed
@ffreyer ffreyer deleted the ff/ReferenceUpdater_fix branch October 15, 2024 18:08
@MakieBot
Copy link
Collaborator

MakieBot commented Oct 15, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 5.04s (5.00, 5.08) 0.03+- 108.59ms (107.89, 109.60) 0.71+- 413.50ms (409.81, 419.42) 3.91+- 9.05ms (8.19, 9.44) 0.58+- 25.92ms (25.64, 27.25) 0.59+-
master 5.03s (5.01, 5.04) 0.01+- 109.34ms (107.39, 111.85) 1.82+- 412.14ms (409.71, 419.60) 3.48+- 9.19ms (8.23, 9.41) 0.42+- 25.70ms (25.64, 25.76) 0.05+-
evaluation 1.00x invariant, 0.01s (0.49d, 0.39p, 0.02std) 1.01x invariant, -0.75ms (-0.54d, 0.34p, 1.27std) 1.00x invariant, 1.35ms (0.37d, 0.51p, 3.70std) 1.02x invariant, -0.15ms (-0.29d, 0.60p, 0.50std) 0.99x invariant, 0.22ms (0.53d, 0.36p, 0.32std)
CairoMakie 4.96s (4.87, 5.07) 0.06+- 112.02ms (110.23, 115.17) 1.84+- 172.74ms (167.77, 185.11) 6.36+- 9.57ms (9.22, 9.80) 0.18+- 1.21ms (1.15, 1.25) 0.03+-
master 4.91s (4.88, 4.97) 0.03+- 110.40ms (109.21, 111.89) 0.93+- 167.77ms (166.13, 168.68) 0.96+- 9.27ms (9.12, 9.55) 0.14+- 1.16ms (1.15, 1.23) 0.03+-
evaluation 0.99x invariant, 0.04s (0.86d, 0.14p, 0.05std) 0.99x invariant, 1.62ms (1.11d, 0.07p, 1.39std) 0.97x invariant, 4.97ms (1.09d, 0.08p, 3.66std) 0.97x slower X, 0.3ms (1.87d, 0.00p, 0.16std) 0.96x slower X, 0.05ms (1.71d, 0.01p, 0.03std)
WGLMakie 5.65s (5.53, 5.80) 0.10+- 111.56ms (109.72, 115.40) 2.52+- 4.76s (4.63, 4.93) 0.11+- 12.10ms (11.73, 12.70) 0.42+- 118.83ms (116.71, 121.76) 1.68+-
master 5.41s (5.24, 5.65) 0.16+- 112.89ms (108.50, 119.91) 5.00+- 5.48s (5.20, 5.76) 0.22+- 12.49ms (11.89, 12.90) 0.33+- 116.69ms (112.32, 119.31) 2.34+-
evaluation 0.96x slower X, 0.24s (1.78d, 0.01p, 0.13std) 1.01x invariant, -1.33ms (-0.34d, 0.54p, 3.76std) 1.15x faster✅, -0.72s (-4.16d, 0.00p, 0.17std) 1.03x invariant, -0.39ms (-1.04d, 0.08p, 0.37std) 0.98x invariant, 2.14ms (1.05d, 0.08p, 2.01std)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog enforcer
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants