Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Toggle to use tick updates instead of an async task for the animation #4482

Merged
merged 6 commits into from
Oct 15, 2024

Conversation

jkrumbiegel
Copy link
Member

No description provided.

@jkrumbiegel jkrumbiegel added the skip-changelog Skips changelog enforcer label Oct 15, 2024
@MakieBot
Copy link
Collaborator

MakieBot commented Oct 15, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 5.26s (5.04, 5.47) 0.16+- 116.99ms (108.06, 127.97) 7.36+- 456.78ms (415.09, 495.25) 33.42+- 9.49ms (8.33, 10.62) 0.84+- 26.70ms (25.99, 27.15) 0.37+-
master 5.34s (5.13, 5.44) 0.11+- 118.69ms (112.16, 125.94) 4.35+- 440.07ms (423.75, 456.80) 10.26+- 9.52ms (8.78, 10.32) 0.54+- 26.80ms (26.62, 27.27) 0.24+-
evaluation 1.01x invariant, -0.08s (-0.58d, 0.30p, 0.13std) 1.01x invariant, -1.71ms (-0.28d, 0.61p, 5.85std) 0.96x invariant, 16.72ms (0.68d, 0.25p, 21.84std) 1.00x invariant, -0.03ms (-0.04d, 0.94p, 0.69std) 1.00x invariant, -0.1ms (-0.31d, 0.57p, 0.30std)
CairoMakie 4.85s (4.81, 4.97) 0.05+- 109.61ms (107.83, 112.30) 1.84+- 166.13ms (163.59, 169.39) 2.38+- 9.31ms (9.08, 9.60) 0.21+- 1.16ms (1.14, 1.23) 0.03+-
master 4.86s (4.81, 4.90) 0.03+- 109.64ms (108.14, 111.22) 1.12+- 166.09ms (164.85, 168.99) 1.35+- 9.25ms (9.17, 9.41) 0.08+- 1.15ms (1.14, 1.16) 0.01+-
evaluation 1.00x invariant, -0.0s (-0.08d, 0.88p, 0.04std) 1.00x invariant, -0.02ms (-0.02d, 0.98p, 1.48std) 1.00x invariant, 0.04ms (0.02d, 0.97p, 1.86std) 0.99x invariant, 0.06ms (0.40d, 0.48p, 0.14std) 0.99x invariant, 0.01ms (0.50d, 0.38p, 0.02std)
WGLMakie 5.55s (5.39, 5.75) 0.13+- 116.94ms (109.13, 124.09) 5.81+- 5.41s (5.21, 5.59) 0.13+- 13.54ms (12.77, 14.74) 0.63+- 117.12ms (114.76, 120.30) 2.03+-
master 5.65s (5.50, 5.78) 0.10+- 114.16ms (108.24, 124.83) 5.64+- 5.12s (4.91, 5.26) 0.12+- 12.40ms (11.53, 13.73) 0.84+- 120.90ms (115.21, 125.09) 3.38+-
evaluation 1.02x invariant, -0.1s (-0.88d, 0.13p, 0.12std) 0.98x invariant, 2.77ms (0.48d, 0.38p, 5.73std) 0.95x slower❌, 0.29s (2.32d, 0.00p, 0.13std) 0.92x slower❌, 1.13ms (1.52d, 0.02p, 0.74std) 1.03x faster ✓, -3.78ms (-1.36d, 0.03p, 2.70std)

@jkrumbiegel jkrumbiegel merged commit 9f49bb0 into master Oct 15, 2024
17 checks passed
@jkrumbiegel jkrumbiegel deleted the jk/toggle-ticks-refactor branch October 15, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog enforcer
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants