-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WGLMakie relocatability #4467
WGLMakie relocatability #4467
Conversation
do your tests cover font handling? i had trouble relocating without the explicit conversion to |
As mentioned in that other PRs comments, I think that was a side effect of the incorrect use of |
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
|
This PR adds only the necessary changes from #3882 to the recent GLMakie relocatability PR #4461. I confirmed locally that this allows to compile a relocatable WGLMakie app using the script that @SimonDanisch introduced in #4461
After both #4461 and this are merged, we can update #4288 so that CI tests CairoMakie and WGLMakie for relocatability as well. Last status there was that I had gotten it to work for CairoMakie but WGLMakie got stuck in CI, probably due to an incorrect setup with
xvfb
or Electron or so. As I tested locally that it can work, this should not be a fundamental issue.