Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't return false early just because one MIME type isn't displayable #3403

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

jkrumbiegel
Copy link
Member

This caused a bug, for example in VSCode Jupyter Notebook mode, where the plot would not be shown inline ever.

@MakieBot
Copy link
Collaborator

MakieBot commented Nov 23, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 3.51s (3.40, 3.61) 0.08+- 547.82ms (529.84, 577.32) 20.37+- 485.20ms (472.93, 506.75) 12.84+- 7.79ms (7.49, 8.02) 0.22+- 26.01ms (25.53, 26.37) 0.39+-
master 3.47s (3.38, 3.61) 0.07+- 547.13ms (520.69, 581.09) 25.28+- 488.55ms (474.43, 518.19) 17.09+- 7.79ms (7.40, 8.24) 0.30+- 25.89ms (25.48, 26.49) 0.36+-
evaluation 0.99x invariant, 0.04s (0.47d, 0.40p, 0.08std) 1.00x invariant, 0.68ms (0.03d, 0.96p, 22.82std) 1.01x invariant, -3.35ms (-0.22d, 0.69p, 14.96std) 1.00x invariant, 0.0ms (0.01d, 0.98p, 0.26std) 1.00x invariant, 0.12ms (0.32d, 0.56p, 0.38std)
CairoMakie 2.85s (2.83, 2.87) 0.01+- 334.19ms (328.60, 341.37) 4.00+- 141.94ms (140.59, 144.54) 1.56+- 7.41ms (7.31, 7.48) 0.06+- 605.14μs (597.98, 615.16) 6.15+-
master 2.85s (2.83, 2.86) 0.01+- 334.99ms (333.33, 337.54) 1.63+- 143.65ms (140.32, 146.54) 2.47+- 7.44ms (7.34, 7.53) 0.07+- 608.55μs (603.15, 615.71) 5.40+-
evaluation 1.00x invariant, 0.01s (0.60d, 0.28p, 0.01std) 1.00x invariant, -0.8ms (-0.26d, 0.64p, 2.81std) 1.01x invariant, -1.71ms (-0.83d, 0.15p, 2.01std) 1.00x invariant, -0.04ms (-0.54d, 0.33p, 0.07std) 1.01x invariant, -3.4μs (-0.59d, 0.29p, 5.78std)
WGLMakie 3.67s (3.56, 3.84) 0.10+- 558.02ms (535.57, 610.14) 26.79+- 8.91s (8.58, 9.25) 0.29+- 9.80ms (9.54, 10.15) 0.21+- 69.86ms (67.34, 74.82) 2.86+-
master 3.69s (3.57, 3.77) 0.08+- 347.75ms (324.63, 359.59) 14.53+- 9.30s (8.91, 9.60) 0.26+- 10.42ms (9.58, 13.24) 1.27+- 70.83ms (67.65, 75.40) 3.16+-
evaluation 1.01x invariant, -0.03s (-0.28d, 0.61p, 0.09std) 0.62x slower❌, 210.26ms (9.76d, 0.00p, 20.66std) 1.04x faster ✓, -0.39s (-1.41d, 0.02p, 0.28std) 1.06x noisy🤷‍♀️, -0.61ms (-0.67d, 0.25p, 0.74std) 1.01x invariant, -0.97ms (-0.32d, 0.56p, 3.01std)

@SimonDanisch SimonDanisch merged commit 6aea596 into master Nov 23, 2023
15 checks passed
@SimonDanisch SimonDanisch deleted the jk/displayable-bug branch November 23, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants