Deprecate using AbstractVector
as side of ImageLike
#3395
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've clearly separated these concepts for 0.20, I think it doesn't make sense anymore to just accept whatever AbstractVector as the side of an ImageLike. Note that
1 .. 10
works and so does1:10
, which might feel correct, but this doesn't have to match the pixel count so it's a source of bugs. And[10, 1]
works as wells as[10, 3, 5, 1, 1, 3, 1]
which is just really strange.