Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regressions #3104

Merged
merged 8 commits into from
Jul 31, 2023
Merged

Fix regressions #3104

merged 8 commits into from
Jul 31, 2023

Conversation

SimonDanisch
Copy link
Member

@SimonDanisch SimonDanisch commented Jul 28, 2023

@MakieBot
Copy link
Collaborator

MakieBot commented Jul 28, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 10.92s (10.87, 11.03) 0.06+- 1.03s (1.02, 1.05) 0.01+- 738.61ms (725.18, 788.46) 22.46+- 9.65ms (9.53, 9.73) 0.07+- 141.01ms (139.85, 142.40) 0.90+-
master 10.95s (10.84, 11.05) 0.07+- 1.04s (1.00, 1.06) 0.02+- 743.63ms (735.49, 767.62) 11.32+- 9.74ms (9.63, 9.81) 0.07+- 140.48ms (139.59, 142.56) 1.04+-
evaluation -0.26%, -0.03s invariant (-0.44d, 0.43p, 0.06std) -0.89%, -0.01s invariant (-0.59d, 0.30p, 0.01std) -0.68%, -5.02ms invariant (-0.28d, 0.61p, 16.89std) -0.94%, -0.09ms faster ✓ (-1.32d, 0.03p, 0.07std) +0.37%, 0.53ms invariant (0.55d, 0.33p, 0.97std)
CairoMakie 10.61s (10.55, 10.80) 0.09+- 1.03s (1.01, 1.05) 0.01+- 216.60ms (213.65, 221.32) 2.63+- 10.44ms (10.30, 10.55) 0.09+- 6.27ms (6.11, 6.42) 0.09+-
master 10.58s (10.55, 10.64) 0.04+- 1.02s (1.01, 1.04) 0.01+- 216.38ms (213.12, 218.40) 1.90+- 10.50ms (10.46, 10.62) 0.05+- 6.34ms (6.27, 6.40) 0.05+-
evaluation +0.28%, 0.03s invariant (0.43d, 0.45p, 0.06std) +0.37%, 0.0s invariant (0.35d, 0.53p, 0.01std) +0.10%, 0.21ms invariant (0.09d, 0.86p, 2.27std) -0.61%, -0.06ms invariant (-0.83d, 0.15p, 0.07std) -1.05%, -0.07ms invariant (-0.92d, 0.12p, 0.07std)
WGLMakie 15.46s (15.15, 15.66) 0.18+- 1.41s (1.38, 1.44) 0.03+- 14.13s (14.02, 14.24) 0.07+- 16.79ms (15.89, 17.74) 0.71+- 1.41s (1.37, 1.44) 0.02+-
master 15.62s (15.46, 15.92) 0.15+- 1.44s (1.37, 1.53) 0.06+- 14.17s (14.03, 14.38) 0.13+- 17.34ms (16.20, 19.08) 0.88+- 1.40s (1.36, 1.43) 0.03+-
evaluation -1.06%, -0.16s invariant (-0.99d, 0.09p, 0.16std) -2.32%, -0.03s invariant (-0.70d, 0.23p, 0.04std) -0.28%, -0.04s invariant (-0.39d, 0.49p, 0.10std) -3.28%, -0.55ms invariant (-0.69d, 0.22p, 0.80std) +0.90%, 0.01s invariant (0.51d, 0.36p, 0.02std)

@SimonDanisch SimonDanisch merged commit cdbb746 into master Jul 31, 2023
13 checks passed
@SimonDanisch SimonDanisch deleted the sd/regression-fixes branch July 31, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animations: possible regression in colour updates using default colorscale and GLMakie
2 participants