Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance of buffer in mesh code #3076

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

SimonDanisch
Copy link
Member

No description provided.

@MakieBot
Copy link
Collaborator

MakieBot commented Jul 19, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 13.23s (12.58, 13.95) 0.43+- 1.20s (1.16, 1.26) 0.04+- 805.99ms (760.06, 847.92) 30.33+- 11.84ms (11.35, 12.40) 0.41+- 104.22ms (102.04, 106.30) 1.64+-
master 13.26s (12.83, 13.85) 0.35+- 1.19s (1.15, 1.25) 0.04+- 807.89ms (781.00, 832.18) 18.85+- 11.99ms (11.47, 12.35) 0.36+- 103.59ms (101.28, 107.37) 2.24+-
evaluation -0.21%, -0.03s invariant (-0.07d, 0.89p, 0.39std) +0.64%, 0.01s invariant (0.20d, 0.72p, 0.04std) -0.24%, -1.89ms invariant (-0.08d, 0.89p, 24.59std) -1.26%, -0.15ms invariant (-0.39d, 0.48p, 0.39std) +0.61%, 0.63ms invariant (0.32d, 0.56p, 1.94std)
CairoMakie 10.30s (10.20, 10.43) 0.08+- 1.03s (1.02, 1.04) 0.01+- 210.83ms (209.20, 213.23) 1.50+- 10.27ms (10.21, 10.35) 0.05+- 6.08ms (5.94, 6.15) 0.08+-
master 10.42s (10.35, 10.52) 0.05+- 1.04s (1.03, 1.05) 0.01+- 225.61ms (221.91, 231.57) 3.10+- 10.54ms (10.45, 10.60) 0.05+- 6.24ms (6.19, 6.28) 0.04+-
evaluation -1.23%, -0.13s faster ✓ (-1.95d, 0.00p, 0.06std) -0.80%, -0.01s invariant (-0.99d, 0.09p, 0.01std) -7.01%, -14.78ms faster✅ (-6.07d, 0.00p, 2.30std) -2.65%, -0.27ms faster ✓ (-5.57d, 0.00p, 0.05std) -2.51%, -0.15ms faster ✓ (-2.51d, 0.00p, 0.06std)
WGLMakie 17.28s (16.82, 17.69) 0.33+- 1.69s (1.60, 1.81) 0.08+- 16.51s (16.20, 16.84) 0.23+- 24.99ms (22.64, 29.59) 2.26+- 1.56s (1.49, 1.65) 0.05+-
master 17.28s (17.09, 17.63) 0.19+- 1.73s (1.65, 1.84) 0.06+- 16.39s (16.12, 16.82) 0.23+- 23.21ms (22.38, 24.92) 0.98+- 1.58s (1.55, 1.69) 0.05+-
evaluation +0.04%, 0.01s invariant (0.02d, 0.97p, 0.26std) -2.12%, -0.04s invariant (-0.53d, 0.34p, 0.07std) +0.70%, 0.12s invariant (0.50d, 0.37p, 0.23std) +7.11%, 1.78ms noisy🤷‍♀️ (1.02d, 0.09p, 1.62std) -1.77%, -0.03s invariant (-0.55d, 0.33p, 0.05std)

@SimonDanisch SimonDanisch merged commit bbb4ef7 into master Jul 20, 2023
13 checks passed
@SimonDanisch SimonDanisch deleted the sd/improve-buffer-perf branch July 20, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants