Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hexbin weights #3074

Merged
merged 12 commits into from
Jul 19, 2023
Merged

hexbin weights #3074

merged 12 commits into from
Jul 19, 2023

Conversation

SimonDanisch
Copy link
Member

@SimonDanisch SimonDanisch commented Jul 18, 2023

Continuation of #2712

@SimonDanisch SimonDanisch mentioned this pull request Jul 18, 2023
5 tasks
@MakieBot
Copy link
Collaborator

MakieBot commented Jul 18, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 11.05s (10.91, 11.27) 0.12+- 1.09s (1.08, 1.10) 0.01+- 805.25ms (785.67, 883.65) 35.23+- 10.01ms (9.90, 10.14) 0.08+- 89.38ms (88.79, 90.11) 0.44+-
master 11.02s (10.99, 11.07) 0.03+- 1.08s (1.08, 1.09) 0.01+- 788.61ms (784.99, 792.93) 3.55+- 10.01ms (9.98, 10.03) 0.02+- 89.22ms (88.54, 90.02) 0.51+-
evaluation +0.25%, 0.03s invariant (0.33d, 0.56p, 0.07std) +0.24%, 0.0s invariant (0.35d, 0.52p, 0.01std) +2.07%, 16.64ms invariant (0.66d, 0.26p, 19.39std) +0.04%, 0.0ms invariant (0.07d, 0.90p, 0.05std) +0.17%, 0.15ms invariant (0.32d, 0.56p, 0.47std)
CairoMakie 10.54s (10.42, 10.65) 0.08+- 1.19s (1.17, 1.20) 0.01+- 229.10ms (223.41, 237.80) 4.87+- 10.71ms (10.57, 10.82) 0.11+- 6.17ms (6.02, 6.26) 0.08+-
master 10.61s (10.42, 10.74) 0.10+- 1.19s (1.19, 1.21) 0.01+- 230.31ms (226.37, 233.26) 2.28+- 10.76ms (10.65, 10.81) 0.06+- 6.19ms (6.11, 6.25) 0.06+-
evaluation -0.64%, -0.07s invariant (-0.74d, 0.19p, 0.09std) -0.42%, -0.0s invariant (-0.50d, 0.38p, 0.01std) -0.53%, -1.21ms invariant (-0.32d, 0.57p, 3.57std) -0.46%, -0.05ms invariant (-0.58d, 0.31p, 0.08std) -0.33%, -0.02ms invariant (-0.28d, 0.61p, 0.07std)
WGLMakie 14.09s (13.77, 14.39) 0.25+- 1.44s (1.37, 1.50) 0.05+- 12.49s (12.16, 12.83) 0.29+- 19.37ms (16.04, 33.93) 6.48+- 1.24s (1.20, 1.28) 0.03+-
master 14.03s (13.72, 14.37) 0.29+- 1.50s (1.40, 1.81) 0.14+- 12.45s (12.14, 12.86) 0.27+- 16.93ms (15.25, 17.82) 1.11+- 1.22s (1.19, 1.25) 0.02+-
evaluation +0.40%, 0.06s invariant (0.20d, 0.71p, 0.27std) -4.32%, -0.06s invariant (-0.57d, 0.32p, 0.10std) +0.33%, 0.04s invariant (0.15d, 0.79p, 0.28std) +12.57%, 2.43ms noisy🤷‍♀️ (0.52d, 0.36p, 3.80std) +1.71%, 0.02s invariant (0.79d, 0.17p, 0.03std)

@SimonDanisch
Copy link
Member Author

RPRMakie should be fixed after JuliaRegistries/General#87785 is merged

@SimonDanisch SimonDanisch merged commit 05b03a7 into master Jul 19, 2023
12 of 13 checks passed
@SimonDanisch SimonDanisch deleted the sd/hexbin_weights branch July 19, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants