Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add smart fillto to enable logscale y-axis histogram barplot #3004

Merged
merged 11 commits into from
Jul 14, 2023
Merged

add smart fillto to enable logscale y-axis histogram barplot #3004

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ffc3864
add smart fillto to enable logscale y-axis histogram barplot
Moelf Jun 13, 2023
456f20f
handle empty bins
Moelf Jun 13, 2023
e13618c
Update src/basic_recipes/barplot.jl
Moelf Jun 13, 2023
daf0e97
add referecen test
Moelf Jun 13, 2023
0581c64
Update ReferenceTests/src/tests/examples2d.jl
Moelf Jun 13, 2023
f2f2fdc
also deal with x-scale log
Moelf Jun 14, 2023
7d8a94d
use stable rng
SimonDanisch Jul 6, 2023
6ea538e
Merge branch 'master' into log_yscale_barplot_smart_fillto
SimonDanisch Jul 6, 2023
70a02b1
Merge branch 'master' into log_yscale_barplot_smart_fillto
Moelf Jul 11, 2023
6528c7c
add x dir to tests
jkrumbiegel Jul 14, 2023
72b841a
Merge branch 'master' into log_yscale_barplot_smart_fillto
jkrumbiegel Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ReferenceTests/src/tests/examples2d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,6 +909,24 @@ end
f
end

@reference_test "Log y-scale histogram (barplot)" begin
# make a gap in histogram as edge case
Moelf marked this conversation as resolved.
Show resolved Hide resolved
hist(
randn(10^6);
axis=(; yscale=log2)
)
current_figure()
end

@reference_test "Log y-scale histogram (barplot) with gap" begin
# make a gap in histogram as edge case
hist(
filter!(x-> x<0 || x > 1.5, randn(10^6));
axis=(; yscale=log10)
)
current_figure()
end

@reference_test "Stephist" begin
stephist(RNG.rand(10000))
current_figure()
Expand Down