Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data_limits dispatch for Mesh to omit slow iteration over buffer #2874

Closed
wants to merge 10 commits into from
Closed

data_limits dispatch for Mesh to omit slow iteration over buffer #2874

Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2166335
data_limits dispatch for Mesh to omit slow iteration over buffer
koehlerson Apr 20, 2023
2fd3aa5
Merge branch 'master' into mk/datalimits_mesh
koehlerson Apr 20, 2023
406f507
restrict dispatch to GeometryBasics.Mesh arg
koehlerson Apr 20, 2023
9cbd0ec
still no allocs, but slower as it could be, should be general bbox
koehlerson Apr 20, 2023
d4de926
faster and non-allocating. however, if bbox_mesh in data_limits moved…
koehlerson Apr 20, 2023
16b0413
fix dimensional issue and ignore NaNs and Infs
koehlerson Apr 21, 2023
882b7f3
dimension agnostic
koehlerson Apr 21, 2023
9c91c7c
restrict dispatch to meshes
koehlerson Apr 21, 2023
60a0dc7
data_limits for Vector{GeometryBasics.Mesh}
koehlerson Apr 21, 2023
ce431d4
Merge branch 'master' into mk/datalimits_mesh
koehlerson Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions src/layouting/data_limits.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,19 @@ function data_limits(plot::Surface)
return Rect3f(mini, maxi .- mini)
end

function data_limits(plot::Mesh)
xyz = plot.mesh[].position
mini, maxi = bbox_mesh(xyz)
if length(mini) == 2
koehlerson marked this conversation as resolved.
Show resolved Hide resolved
mini = Vec3f(mini...,0)
maxi = Vec3f(maxi...,0)
else
mini = Vec3f(mini)
maxi = Vec3f(maxi)
end
return Rectf(mini, maxi .- mini)
end

function data_limits(plot::Heatmap)
mini_maxi = extrema_nan.((plot.x[], plot.y[]))
mini = Vec3f(first.(mini_maxi)..., 0)
Expand All @@ -222,3 +235,23 @@ function data_limits(plot::Image)
maxi = Vec3f(last.(mini_maxi)..., 0)
return Rect3f(mini, maxi .- mini)
end

function bbox_mesh(coords)
dim = length(coords[1])
mini = [xyz for xyz in coords[1]]
maxi = [xyz for xyz in coords[1]]
for coord in coords
for d in 1:dim
if isnan(coord[d]) || isinf(coord[d])
continue
end
if coord[d] < mini[d]
mini[d] = coord[d]
elseif coord[d] > maxi[d]
maxi[d] = coord[d]
end
end
koehlerson marked this conversation as resolved.
Show resolved Hide resolved
end
return (mini,maxi)
end