Skip to content

Commit

Permalink
match modelinv assert with GLMakie
Browse files Browse the repository at this point in the history
  • Loading branch information
ffreyer committed Oct 7, 2024
1 parent cfe8c5f commit 0532d6a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions WGLMakie/src/serialization.jl
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ function serialize_three(scene::Scene, @nospecialize(plot::AbstractPlot))
Makie.scalematrix(Vec3f(width ./ size(chunk))) *
Makie.translationmatrix(Vec3f(mini))
modelinv = inv(_model)
@assert modelinv[4, 4] 1
@assert isapprox(modelinv[4, 4], 1, atol = 1e-6)

output = Vector{Vec4f}(undef, 8)
for i in 1:min(length(planes), 8)
Expand Down Expand Up @@ -421,7 +421,7 @@ function serialize_three(scene::Scene, @nospecialize(plot::AbstractPlot))
# with just applying it to the plane origin and transpose(inv(modelinv))
# to plane.normal
modelinv = inv(model)
@assert modelinv[4, 4] 1
@assert isapprox(modelinv[4, 4], 1, atol = 1e-6)

output = Vector{Vec4f}(undef, 8)
for i in 1:min(length(planes), 8)
Expand Down

0 comments on commit 0532d6a

Please sign in to comment.