bring back matrix arguments for poly

MakieOrg · Aug 27, 2024 · 017b696 · 017b696
1 parent bdbed7c
commit 017b696
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## [Unreleased]
 
+- Bring back `poly` convert arguments for matrix with points as row [#4266](https://github.com/MakieOrg/Makie.jl/pull/4258).
+
 ## [0.21.9] - 2024-08-27
 
 - Hotfix for colormap + color updates [#4258](https://github.com/MakieOrg/Makie.jl/pull/4258).

diff --git a/src/basic_recipes/poly.jl b/src/basic_recipes/poly.jl
@@ -20,6 +20,9 @@ function convert_arguments(::Type{<:Poly}, path::BezierPath)
     return convert_pointlike(path)
 end
 
+function convert_arguments(::Type{<:Poly}, path::AbstractMatrix{<:Number})
+    return convert_pointlike(path)
+end
 
 function convert_arguments(::Type{<:Poly}, vertices::AbstractArray, indices::AbstractArray)
     return convert_arguments(Mesh, vertices, indices)

diff --git a/test/conversions.jl b/test/conversions.jl
@@ -312,6 +312,12 @@ end
     @test pl.plots[1][1][][1] == Makie.poly_convert(points)
 end
 
+@testset "Poly with matrix" begin
+    x1 = [0.0, 1, 1, 0, 0]
+    y1 = [0.0, 0, 1, 1, 0]
+    @test convert_arguments(Poly, hcat(x1, y1))[1] == Point.(x1, y1)
+end
+
 @testset "GridBased and ImageLike conversions" begin
     # type tree
     @test GridBased <: ConversionTrait