-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(retro): adds the possibility to add coments #122
Conversation
added editable comments only for moderator and creator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your PR! I noticed some things during testing that I would like to share with you.
When you open the comments dialog:
- The first card that you display, doesn't handle line breaks when having for example a card with multi-line content. In my opinion it's not necessary to display the card in the dialog again. I understand your intention behind it and it makes sense when having short and concise cards, but I saw how teams are sometimes writing very long text inside it which would bloat the dialog. So maybe we should leave it out there.
- Speaking of multi-line, the text field where the user can enter a comment cannot handle multi-line as well. The resulting comment is displayed without line breaks.
- I was thinking a bit more about how we handle author names currently. We can keep the current behavior as it is, since it's the same when creating a card, but I thought that it might make sense to have a new feature, where every user provides a name before entering the session. Kind of like it is handled currently in the planning poker section. That way we could remove the need to always pre-fill or even have the ability to enter the author name for everything.
comment dialog
* fixes(retro): card is now not shown in comment dialog * fix(retro): code cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, looking good so far! There are just some small UI/UX things that would be nice.
- If it's possible, remove the cancel button on the bottom of the dialog and instead provide an X icon button on the top right in order to close the dialog.
- On the top of the dialog where the user can enter a comment, extend the text fields to full width and move the send button after the content text field aligned to the end of the row. Similar to MS Teams for example. You could maybe use a button with icon and label. The label can have the value "Send". More here: https://mui.com/components/buttons/#buttons-with-icons-and-label
- I think it's better if we move the edit and delete button on the same row as the name of the author and align it to the end of the row. Same for the "save" and "close" buttons when you editing a comment
- Lastly, you could also apply the logic for having clickable URLs in the content section, since most of the time participants are referring to some content via URLs.
If we have these, we can do the merge. Very excited to release this feature. Thanks a lot!
Closing this one since we can't apply this PR to the new codebase. The issue will be evaluated and prioritized in the future. |
Adding comments to cards would be possible with these changes
Solves: #60
Functionality
Boundaries
Possibilities
Current View