Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement partial reading for ISMRMRD files #100

Closed
wants to merge 3 commits into from

Conversation

tknopp
Copy link
Member

@tknopp tknopp commented Sep 4, 2022

This is a first attempt to implement partial reading from ISMRMRD files (closes #76).
What is still missing is the fix of the header. I do not yet have an idea how to do that. We probably want to allow just UnitRanges for the applied slice argument.

@mrikasper @alexjaffray: I don't have data with multiple slices / repetitions at hand. Would be great if you could give this a test + help me fixing the header. The test should include timing. I expect that the sliced reading should be faster and acquire only the memory required for the slice. But I am only 90% sure about that.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2022

Codecov Report

Base: 64.23% // Head: 64.23% // No change to project coverage 👍

Coverage data is based on head (011bd8a) compared to base (dcf7799).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   64.23%   64.23%           
=======================================
  Files          37       37           
  Lines        1675     1675           
=======================================
  Hits         1076     1076           
  Misses        599      599           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexjaffray
Copy link
Contributor

Thanks for looping me in @tknopp. @mrikasper and I have spiral data available at https://zenodo.org/record/6510021#.Yxe_7y0r1QI and are just thinking about how to package it into a small, test-friendly example. I'l take a look at this branch and see what we need to do to make it work with our dataset.

@tknopp
Copy link
Member Author

tknopp commented Sep 7, 2022

For the unit tests we could alternatively simulate some ISMRMRD files with our internal simulation framework. This would be more flexible.

tknopp added a commit that referenced this pull request Oct 11, 2022
@tknopp
Copy link
Member Author

tknopp commented Oct 11, 2022

committed directly in 2e29cb9 since this had conflicts.

@tknopp tknopp closed this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial (or lazy) Loading of RawAcquisitionData
3 participants