-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial (or lazy) Loading of RawAcquisitionData #76
Comments
We might be able to create a minimum example from this code https://github.com/mrikasper/julia-recon-advances-in-spiral-fmri related to the spiral fMRI paper and data we published. As you see in the main.jl L65, I already tried a crude version of extracting a single slice only and adjusting the header for that. What should the minimal example do? Load the sliced data and check to the corresponding subset of data after full loading of all data? I am not sure whether this is already the case in All the best, |
Ok, so its not just about the slice dimension but it would be helpful to also select partial data for other dimensions. Then we should use keyword arguments that are passed to the
|
The ugly part is the need to change Basically one can use your code as the blueprint for moving that stuff into The most crucial part, however, will be to change this line: Edit: Partial reading seems not be supported by the regular "high-level" HDF5.jl routines but according to this C example it should be doable using the low-level HDF5 API: https://www.asc.ohio-state.edu/wilkins.5/computing/HDF/hdf5tutorial/examples/C/h5_compound.c |
@tknopp can you update the link? it's broken after #72 was merged. |
done |
I am splitting of this feature request from #73 since this would be easier to implement for ISMRMRD.
@mrikasper @alexjaffray: Could you come up with a small simple example of what you have in mind here? Ideally you would design a small minimal example that we need for the test suite anyway. The example can be small and simulation based but it should represent your use case well.
From my understanding one wants something like
If that is correct we would need to somehow filter profiles in this for loop
https://github.com/MagneticResonanceImaging/MRIReco.jl/blob/master/MRIFiles/src/ISMRMRD/ISMRMRD.jl#L25
All this should IMHO happen while loading the
RawDataAcquisition
object.The text was updated successfully, but these errors were encountered: