Merge pull request #1378 from xaviliz/framebuffer

Framebuffer - Issue in PitchYINFFT when no peaks are detected.
MTG · Sep 26, 2023 · 6e16631 · 6e16631
2 parents 5b378d8 + ee31729
commit 6e16631
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/algorithms/tonal/pitchyinfft.cpp b/src/algorithms/tonal/pitchyinfft.cpp
@@ -189,8 +189,9 @@ void PitchYinFFT::compute() {
       yinMin = -_amplitudes[0];
     }
     else {
-      // TODO this should never happen, but some people reported it happening in their real time applications.
-      throw EssentiaException("PitchYinFFT: it appears that no peaks were found by PeakDetection. If you read this message, PLEASE, report this issue to the developers with an example of audio on which it happened.");
+      tau = 0.0; // it will provide zero-pitch and zero-pitch confidence.
+      // launch warning message for user feedbacking
+      E_WARNING("PitchYinFFT: it appears that no peaks were found by PeakDetection algorithm. So, pitch and confidence will be set to zero.");
     }
   }
   else {