Add tracking of total rewards given to enemies on player death #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LoneWolfHT, can you review this PR? It doesn't affect the balance of the game, and the changes are minimal. It adds one stat to the summary. |
|
I feel like this could be a stat you track in memory and insert into the summary, instead of storing it in player rankings forever. Did you just want it in the summary? |
|
When it was suggested, I mentioned adding it to both the summary and statistics (leaderboard). So, it's storing this stat for player rankings as well. When I implemented it for the summary, the implementation worked for both the summary and player rankings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion: link