Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Build Type: Tpetra" from Landice tests #788

Closed

Conversation

mcarlson801
Copy link
Contributor

@mcarlson801 mcarlson801 commented Mar 11, 2024

Support for Epetra in Albany has been deprecated and therefore "Build Type:" is no longer a valid parameter for landice tests. This PR removes the option from all landice tests.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@mcarlson801
Copy link
Contributor Author

Testing

All compass tests on perlmutter are passing with this branch: https://my.cdash.org/viewTest.php?onlypassed&buildid=2519563

Full test log:
weekly_log_pm_cpu_Compass.txt

@mperego
Copy link
Contributor

mperego commented Mar 13, 2024

@mcarlson801 can you update the PR description with the new Albany and Trilinos tags, once you create them?

@mcarlson801
Copy link
Contributor Author

New Albany/Trilinos tags that will work with these updated tests:

Albany: https://github.com/sandialabs/Albany/releases/tag/compass-2024-03-13
Trilinos: https://github.com/E3SM-Project/Trilinos/releases/tag/compass-2024-03-13

@mperego
Copy link
Contributor

mperego commented Mar 13, 2024

@xylar: It's probably better to merge this PR when you update the compass/spack builds on Perlmutter using the new Albany and Trilinos tags above.

@xylar
Copy link
Collaborator

xylar commented Mar 14, 2024

@mcarlson801, @mperego and @matthewhoffman, as I just wrote to @matthewhoffman on Slack, this will need to become part of a PR that update the compass version number and the spack builds on all supported machines (not just Perlmutter).

If @andrewdnolan is interested, I will ask for his help in that process. This may take a little time.

@mperego
Copy link
Contributor

mperego commented Mar 14, 2024

Thanks @xylar. I'm sorry that you have to update the builds on all the machines. Unfortunately, Albany is going through a lot of changes, so it is fair to expect that there will be other changes in the future that are not backward compatible.
In general, how often do you plan to update Spack builds? If they are update frequently enough (say, twice a year) we should be able to avoid changes that are not backward compatible without hindering much Albany development.

@xylar
Copy link
Collaborator

xylar commented Mar 14, 2024

@mperego, I don't really have a schedule for when I deploy spack builds. It's just whenever we need a new version of our spack dependencies. Besides Albany and Trilinos, those include ESMF, SCORPIO, MOAB (soon) and their dependencies. So we haven't needed to update very often. Albany is the main driver these days, I think. But it's a good opportunity to update the other Spack package versions.

@xylar
Copy link
Collaborator

xylar commented Mar 14, 2024

@mperego, did you see my note #793 (comment) about not being able to build?

@xylar
Copy link
Collaborator

xylar commented Mar 24, 2024

Merged in #793 along with the compatible spack environment. Thank you @mcarlson801 and @mperego for taking care of this!

@xylar xylar closed this Mar 24, 2024
@mperego
Copy link
Contributor

mperego commented Mar 25, 2024

Thank you @xylar for taking care of updating the spack environment and builds!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants