Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Position Bug #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Save Position Bug #1

wants to merge 1 commit into from

Conversation

Road-block
Copy link

Way to reproduce the position bug for upstream version:

  1. Go into Video Options, check "use UI scale" set it to something other than 1
  2. /whud select Ragebar, set a scale different than 1, position it and close the options
  3. /console reloadui and show options again or generate some rage
    Frame will have moved from its apparent saved position.

I was lazy and didn't try to preserve the CENTER anchor logic and fix the screen coord math, instead:

  • Changed UIParent anchoring to default TOPLEFT and utilized GetEffectiveScale() to store / load proper coordinates.
  • Might need to nuke saved variables if options frame starts off-screen
  • /whudold not updated
  • defaults updated to put the frames somewhere inside the viewport but not necessarily centered.

Repeat steps above for this version, frames will save and load position properly regardless of UIScale + scale settings.

Hope it's of some use

…frame scale

Changed UIParent anchoring to default TOPLEFT
whudold not updated
Might need to nuke saved variables if options frame starts offscreen
@MOUZU
Copy link
Owner

MOUZU commented Jan 13, 2016

Thanks for your effort.

I will review the bug and your changes most likely next week.
I will also have to check if it would be in conflict with the local 'under development' version I currently have which I didn't finish for a few months.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants