-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SP3/refactor] maindashboard orkTree 동작 오류 해결 #327
Open
SooY2
wants to merge
16
commits into
SP3/refactor
Choose a base branch
from
refac/#323/mainDashboardOKR
base: SP3/refactor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: GA 이벤트 탐지를 위한 class name 추가 * chore: class name 수정 * feat: kr/task 삭제에 따른 class name 분기 처리 * feat: 가이드/직접 선택에 따른 class name 분기 처리
* feat : social get fetcher 생성 * feat : social data type 추가 * fix : social 데이터 목 데이터 -> 실제 데이터 연결로 수정 * fix : 안쓰게 된 mock data 파일 삭제
* [Refactor] placeholder 라이팅 수정 (#309) * fix : kr objective placeholder 개선 * fix : 가이드에 따라 설정 시 kr 목표 텍스트 변경 * fix : kr 단위 힌트 메시지 수정 * fix : 가이드에 따라 설정 kr placeholder 재수정 * fix : objContent placeholder 수정 * [Refactor] KR validation 로직 추가 (#310) * fix : krValidation 로직에 krTitle, krMetric 문자만 입력 추가 * fix : 가이드에 따라 설정 - 첫번째 kr 카드 krValid 함수 사용으로 수정
* fix: nickname regex 수정
* chore: 워딩 수정 * chore: 워딩 수정
* chore: 워딩 수정 * fix: 버튼 링크 수정
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SooY2
changed the title
Refac/#323/main dashboard okr
[SP3/refactor] maindashboard orkTree 동작 오류 해결
Oct 20, 2024
커밋이 섞인것 같은데 base 브랜치 기준으로 rebase 쳐서 함 정리해주면 리뷰하기 더 편할것 같습니댜 !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issues
💜 작업 내용
✅ PR Point
view모드에서 보여지는 OKRTree 데이터를 edit모드에서 보여주는 데이터로 변경했습니당
++ 동작 오류 발견하면 말해쥬세요!!
☀️ 스크린샷 / GIF / 화면 녹화
2024-10-20.20.13.12.mov
📚 Reference