-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible solution for checkout modules #61
Open
presteamshop
wants to merge
12
commits into
MONEI:master
Choose a base branch
from
presteamshop:presteamshop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
presteamshop
commented
Oct 8, 2024
- Temporary/fake data is entered to simulate a customer for visitors and allow the quick purchase module to function, showing payment options without requiring a logged-in customer.
- "Payment" cookies are created for the total amount of the cart, to avoid creating multiple payment intents when the cart value is changed.
- Temporary/fake data is entered to simulate a customer for visitors and allow the quick purchase module to function, showing payment options without requiring a logged-in customer. - "Payment" cookies are created for the total amount of the cart, to avoid creating multiple payment intents when the cart value is changed.
- Fake information is no longer sent. Instead, the Customer or Address is not sent to the payment intent if a valid object is not available. - Additionally, when a user logs out, the cookies created by Monei are deleted.
jimmyn
requested changes
Oct 10, 2024
controllers/front/validation.php
Outdated
die('Module is not active'); | ||
} | ||
|
||
$data = Tools::file_get_contents('php://input'); | ||
if (!isset($_SERVER['HTTP_MONEI_SIGNATURE'])) { | ||
die('HTTP_MONEI_SIGNATURE is not set'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not expose what is the reason, just throw Unauthorized error
…o blur on card holder
This is so that if they change their address and that address has another country, I can show the payments according to the new country.
Additionally, validation is performed to create a new payment intention in the event that the payment has been pending and with a payment method association.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.