Skip to content

Commit

Permalink
Revert "Revert "feat(timeit): add function timing decorator (#118)" (#…
Browse files Browse the repository at this point in the history
…119)"

This reverts commit d725ddb.
  • Loading branch information
wpbonelli committed Sep 29, 2023
1 parent d725ddb commit d47f5cf
Show file tree
Hide file tree
Showing 4 changed files with 79 additions and 0 deletions.
1 change: 1 addition & 0 deletions docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ The `modflow-devtools` package provides a set of tools for developing and testin
md/download.md
md/ostags.md
md/zip.md
md/timeit.md


.. toctree::
Expand Down
17 changes: 17 additions & 0 deletions docs/md/timeit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# `timeit`

There is a `timeit` decorator function available in the `modflow_devtools.misc` module. Applying it to any function causes a (rough) runtime benchmark to be printed to `stdout` afterwards the function returns. For instance:

```python
@timeit
def sleep1():
sleep(0.001)

sleep1() # prints e.g. "sleep1 took 1.26 ms"
```

`timeit` can also directly wrap a function:

```python
timeit(sleep1)() # prints same as above
```
37 changes: 37 additions & 0 deletions modflow_devtools/misc.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import importlib
import socket
import sys
import time
import traceback
from contextlib import contextmanager
from functools import wraps
from importlib import metadata
from os import PathLike, chdir, environ, getcwd
from os.path import basename, normpath
Expand Down Expand Up @@ -442,3 +444,38 @@ def try_metadata() -> bool:
_has_pkg_cache[pkg] = found

return _has_pkg_cache[pkg]


def timeit(f):
"""
Decorator for estimating runtime of any function.
Prints estimated time to stdout, in milliseconds.
Parameters
----------
f : function
Function to time.
Notes
-----
Adapted from https://stackoverflow.com/a/27737385/6514033.
Returns
-------
function
The decorated function.
"""

@wraps(f)
def timed(*args, **kw):
ts = time.time()
res = f(*args, **kw)
te = time.time()
if "log_time" in kw:
name = kw.get("log_name", f.__name__.upper())
kw["log_time"][name] = int((te - ts) * 1000)
else:
print(f"{f.__name__} took {(te - ts) * 1000:.2f} ms")
return res

return timed
24 changes: 24 additions & 0 deletions modflow_devtools/test/test_misc.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import os
import re
import shutil
from os import environ
from pathlib import Path
from pprint import pprint
from time import sleep
from typing import List

import pytest
Expand All @@ -15,6 +17,7 @@
has_pkg,
set_dir,
set_env,
timeit,
)


Expand Down Expand Up @@ -283,3 +286,24 @@ def test_has_pkg(virtualenv):
).strip()
== exp
)


def test_timeit1(capfd):
def sleep1():
sleep(0.001)

timeit(sleep1)()
cap = capfd.readouterr()
print(cap.out)
assert re.match(r"sleep1 took \d+\.\d+ ms", cap.out)


def test_timeit2(capfd):
@timeit
def sleep1dec():
sleep(0.001)

sleep1dec()
cap = capfd.readouterr()
print(cap.out)
assert re.match(r"sleep1dec took \d+\.\d+ ms", cap.out)

0 comments on commit d47f5cf

Please sign in to comment.