Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more error information when parsing virtual configs and treat emp… #8

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

nathanhhughes
Copy link
Collaborator

…ty type differently

@Schmluk should be pretty quick, just adding a little bit more context when getType fails when parsing virtual configs and makes empty type strings not result in the list of possible modules

@nathanhhughes nathanhhughes marked this pull request as ready for review March 14, 2024 21:29
Copy link
Collaborator

@Schmluk Schmluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathanhhughes nathanhhughes merged commit 51feae3 into main Mar 14, 2024
2 checks passed
@nathanhhughes nathanhhughes deleted the feature/update_errors branch March 14, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants