Feature/maps #7
Feature/maps #7
Conversation
|
@Schmluk should be ready. I opted to rework how the ADL dispatch works, which lets us now define specializations before |
| @@ -63,9 +63,12 @@ std::string AslFormatter::formatErrorsRecursive(const MetaData& data, const std: | |||
| const std::string name_prefix_before = name_prefix_; | |||
| if (Settings::instance().inline_subconfig_field_names) { | |||
| if (!data.field_name.empty()) { | |||
| // TOOD(nathan) refactor to put in metadata | |||
There was a problem hiding this comment.
I think this is purely a printing problem? Not sure if this needs to go into meta data.
There was a problem hiding this comment.
yeah, I wasn't sure what the right split between formatting the indices/keys and just getting the string values of the indices/keys if they exist was so I punted on figuring it out for now
| @@ -47,7 +47,9 @@ | |||
|
|
|||
| namespace config::test { | |||
|
|
|||
| namespace { | |||
There was a problem hiding this comment.
Just for my understanding, does this hide it from other tests or what is the idea here?
There was a problem hiding this comment.
Sorta, it prevents multiple definitions (I copied the array tests pretty much wholesale for maps and got a multiply-defined symbol error)
@Schmluk about 90% there on the maps; just need to actually take care of printing keys instead of indices (and cleaning up some unintended changes). Will pick this up and finalize it tomorrow morning