Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/arrays #5

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Fix/arrays #5

merged 2 commits into from
Jan 9, 2024

Conversation

nathanhhughes
Copy link
Collaborator

@Schmluk ran into an issue where I couldn't parse nested vectors of configs (new unit test doesn't pass without the associated fix). Pretty sure the namespace works right in all cases, but would be worth getting a quick glance when you get a chance

@nathanhhughes nathanhhughes self-assigned this Jan 4, 2024
Copy link
Collaborator

@Schmluk Schmluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathanhhughes nathanhhughes merged commit 7439d8c into main Jan 9, 2024
2 checks passed
@nathanhhughes nathanhhughes deleted the fix/arrays branch January 9, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants