New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some minor fixes #30

Merged

Schmluk merged 3 commits into MIT-SPARK:main from andre-nguyen:fix/cmake

Sep 13, 2024

Contributor

andre-nguyen commented Sep 6, 2024

Add missing include for std::exchange
Add missing find_dependency call for yaml-cpp in exported cmake config file
Append to CMAKE_MODULE_PATH instead of overriding the variable

andre-nguyen added 3 commits

September 6, 2024 10:37


          fix: add missing find_dependency call

4b48203


          fix[cmake]: append to CMAKE_MODULE_PATH instead of overriding

6a386ea


          fix: missing include

f9a5532

Schmluk approved these changes

View reviewed changes

Collaborator

Schmluk left a comment

LGTM! Thanks for providing these updates!

Schmluk merged commit 96ecbd6 into MIT-SPARK:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet