Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/assign virtual configs #13

Merged
merged 3 commits into from
Apr 27, 2024
Merged

Conversation

Schmluk
Copy link
Collaborator

@Schmluk Schmluk commented Apr 27, 2024

  • Adds assignment operators and constructors for virtual configs and other config structs.
  • Natural initialization does not require specifying the type manually.
  • NOTE: The above may fail if the same config is registered with different names. For now this behavior is supported but will warn the user. Could consider enforcing this to avoid issues in the future.
  • Add utest for new functionality

@nathanhhughes This will break compatibility with the {Config, name} initialization, but I don't think we should support manually specifying the name in the future.

Copy link
Collaborator

@nathanhhughes nathanhhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! fine with me to drop the type string arg / agree that it was kinda error-prone to have to specify it

@Schmluk Schmluk force-pushed the feature/assign_virtual_configs branch from 845d71b to 9f0df8c Compare April 27, 2024 21:30
@Schmluk Schmluk merged commit 8520d3b into main Apr 27, 2024
2 checks passed
@Schmluk Schmluk deleted the feature/assign_virtual_configs branch April 27, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants