Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reformat module registry printing and add utest #12

Merged
merged 4 commits into from
Apr 27, 2024
Merged

reformat module registry printing and add utest #12

merged 4 commits into from
Apr 27, 2024

Conversation

Schmluk
Copy link
Collaborator

@Schmluk Schmluk commented Apr 25, 2024

  • Reformats printing of module registry to be ordered and grouped by module.
  • Add utest to check printing and warning when registering.

@nathanhhughes Turns out the behavior was already as intended, but now I'm sure and the printing looks clearer (hopefully) 🙂

@Schmluk
Copy link
Collaborator Author

Schmluk commented Apr 26, 2024

@nathanhhughes This should now be final 🙂

nathanhhughes
nathanhhughes approved these changes Apr 27, 2024
View reviewed changes
Copy link
Collaborator

@nathanhhughes nathanhhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I really like the new format!

@Schmluk Schmluk merged commit 54cab9d into main Apr 27, 2024
2 checks passed
@Schmluk Schmluk deleted the feature/templated_registration branch April 27, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanhhughes nathanhhughes nathanhhughes approved these changes

@marcusabate marcusabate Awaiting requested review from marcusabate

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Schmluk @nathanhhughes