drop globals

MIT-SPARK · Mar 22, 2024 · 8e80f51 · 8e80f51
1 parent c144f5c
commit 8e80f51
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 277 deletions.
diff --git a/config_utilities/CMakeLists.txt b/config_utilities/CMakeLists.txt
@@ -27,7 +27,6 @@ add_library(
   src/asl_formatter.cpp
   src/conversions.cpp
   src/formatter.cpp
-  src/globals.cpp
   src/logger.cpp
   src/meta_data.cpp
   src/namespacing.cpp

diff --git a/config_utilities/include/config_utilities/globals.h b/config_utilities/include/config_utilities/globals.h
diff --git a/config_utilities/include/config_utilities/validation.h b/config_utilities/include/config_utilities/validation.h
@@ -39,7 +39,6 @@
 #include <string>
 #include <vector>
 
-#include "config_utilities/globals.h"
 #include "config_utilities/internal/formatter.h"
 #include "config_utilities/internal/logger.h"
 #include "config_utilities/internal/visitor.h"
@@ -93,9 +92,7 @@ const ConfigT& checkValid(const ConfigT& config) {
       "for your struct.");
   internal::MetaData data = internal::Visitor::getChecks(config);
 
-  // Write the config data to global storage for later summarization if requested.
   if (internal::hasNoInvalidChecks(data)) {
-    // TODO(nathan) threadsafe registration of configs or remove config registry printing
     return config;
   }
 

diff --git a/config_utilities/src/globals.cpp b/config_utilities/src/globals.cpp
diff --git a/config_utilities/test/CMakeLists.txt b/config_utilities/test/CMakeLists.txt
@@ -39,7 +39,6 @@ add_executable(
   tests/conversions.cpp
   tests/enums.cpp
   tests/factory.cpp
-  tests/globals.cpp
   tests/inheritance.cpp
   tests/namespacing.cpp
   tests/path.cpp

diff --git a/config_utilities/test/tests/globals.cpp b/config_utilities/test/tests/globals.cpp