Order bounding box corners to be plottable #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can fix the unit test if we decide we want to make this change |
|
Also: probably fine to just go into main if you'd like |
nathanhhughes
approved these changes
Jul 13, 2024
|
@GoldenZephyr Can you double check the hydra visualizer still works correctly? I'm not sure if I changed it to use the corners or only meant to do this. Also need to double check the khronos visualizers (maybe global search cornerns()?) Other than that no downstream uses that I know of. |
|
My bad, had checked Hydra and Khronos (at least the private version) but forgot to actually search Hydra-ROS (will push a fix on the ros side) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a reason that the bounding box corners were not in order? It would be much more convenient for plotting or making polygon objects if the vertices were in this order. Are there any downstream ramifications of changing the order?