Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor loggers to allow for different output paths #59

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ToniRV
Copy link
Collaborator

@ToniRV ToniRV commented May 3, 2020

  • Now each logger can have a different output path, but we are only
    using one output path. This is to allow for logging to different dirs
    depending on the current run, without having to kill the pipeline (this
    is for go-seek mainly).
  • Remove log_output gflag and use instead the log_output_path yaml parameter
    in PipelineParams.yaml. If this parameter is empty "" then no logging is done
  • Also cleaned module factories so that they use parameter packs and perfect forwarding.

ToniRV added 6 commits May 3, 2020 16:35
- Now each logger can have a different output path, but we are only
using one output path. This is to allow for logging to different dirs
depending on the current run, without having to kill the pipeline (this
    is for go-seek mainly).
- Remove log_output gflag and use instead the `log_output_path` yaml parameter
in PipelineParams.yaml. If this parameter is empty "" then no logging is done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant