Fix loading/clearing of media files #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2024 15:55
If demo files are placed in first-level subdirectories of the media directory, they were not being copied correctly when loading the demo. For example, "demo-files/media/ethics/Ethics_Approval_....txt" was incorrectly copied as "media/ethics" rather than "media/ethics/Ethics_Approval_....txt". Additionally, ensure that the destination directories are created if they don't already exist.
Previously, resetdb would fail if the media directory contained something that wasn't a subdirectory (such as a file called "ethics" that was created by a buggy version of loaddemo.) We can simplify this function enormously - what we really want is to delete *everything* except for ".gitkeep" files.
|
looks good to me, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
manage.py loaddemoincorrectly creates a file (not a directory) calledmedia/ethics.Even worse,
manage.py resetdbcurrently crashes if that file exists.Fixes #2247