WIP: Add functionality for managing project reviews #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompollard
force-pushed
the
tp/project_reviews
branch
from
396963e
to
6936f70
Compare
tompollard
force-pushed
the
tp/project_reviews
branch
from
6936f70
to
da369af
Compare
|
This is useful, especially if we can capture external reviewers comments. Thanks! |
|
Assuming we would like to go ahead with this change, the pull request will need to be updated to follow the approach used in #2264 |
tompollard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2258, it would be helpful to be able to record reviews of datasets in the editorial system.
This pull request takes a simple approach to addressing this issue by replicating the "Internal notes" functionality that was added in #2255 to support posting of reviews.
Initially project editors would need to request reviews via email and then post the reviews on behalf of reviewers. We could then work towards more complete peer review functionality by: