Configurable production database name and credentials #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2024 16:50
Instead of hard-coding the database hostname, username, and database name, use the config variables DB_HOST, DB_USER, and DB_NAME. Additionally, replace the old DATABASES_PASSWORD with DB_PASSWORD. All four new variables are now required to be defined in .env. This is intended to bring the old settings modules in line with physionet.settings.settings, so that eventually all three can be unified.
The physionet.settings.staging module should now use DB_PASSWORD instead of the old DATABASES_PASSWORD.
|
(And I think it should be "safe" to merge this because I think the git hooks should squawk if the variables are missing, but I'm testing that right now.) |
|
thanks! |
tompollard
added a commit
that referenced
this pull request
Apr 24, 2024
Similar to the DB_HOST and DB_NAME variables (see also pull #2219), add a configuration variable to control the port number for PostgreSQL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuring the production database name (and username and hostname) by bringing these old settings modules in line with the new style config variables used by physionet.settings.settings.
(All these variables should already be set correctly on all our servers, but of course we should check before deploying.)