Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'Archive Events' Page to filter events in the admin console #2078

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

mscanlan-git
Copy link
Contributor

@mscanlan-git mscanlan-git commented Sep 13, 2023

This PR addresses #2026 by adding an "Archived Events" page to eliminate event clutter that will eventually occur over time as we add new events.

EDIT: We will eventually need to change the normal events page to only include events that haven't been archived yet (active/future events). This can be done in a separate PR, though.

Copy link
Member

@tompollard tompollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @mscanlan-git, nice work! I have listed a few quick thoughts below. As this is a private part of the site I'd be happy to merge as it is, and perhaps these can be addressed in a couple of new pull requests?

"""
List of archived events
"""
now = timezone.now()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that it is necessary to assign the now variable here. Event.objects.filter(end_date__lte=timezone.now()) is just as readable.

@tompollard tompollard merged commit 77a1645 into dev Sep 13, 2023
8 checks passed
@tompollard tompollard deleted the archive-events branch September 13, 2023 14:05
@tompollard
Copy link
Member

Now on the live site, thanks again! BTW, minor thing, but don't forget to clean up commit logs before opening a pull request (e.g in this case rolling back the temp commit with git reset XXX and then adding a fresh one).

@mscanlan-git
Copy link
Contributor Author

Thanks @tompollard , I will be looking to add those changes you mentioned in my next PR to address the active events page, to only allow currently actively events.

Also, will keep note on cleaning commits, forgot about the temp commit from yesterday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants